Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for compilers pre g++ version 7, some more conda setup #31

Merged
merged 3 commits into from
Feb 26, 2022
Merged

Fix bug for compilers pre g++ version 7, some more conda setup #31

merged 3 commits into from
Feb 26, 2022

Conversation

gwct
Copy link
Contributor

@gwct gwct commented Feb 22, 2022

This pull request has commits that:

  1. Fixes a bug related to compiling on g++ versions lower than 7 -- See README about GCC newest version #17
  2. Removes the conda recipe and build scripts, which will now live in our fork of bioconda-recipes
  3. Removed the file _config.yml since it didn't seem to be doing anything

@gwct
Copy link
Contributor Author

gwct commented Feb 25, 2022

@xyz111131 when you get a chance can you have a quick look to make sure the changes I made to bpp_c2.c pp don't affect anything downstream in the program? I don't think they will, so just a glance should do.

@xyz111131
Copy link
Collaborator

yeah, the changes should be fine.

@gwct gwct merged commit f3a60cf into phyloacc:main Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyz111131 xyz111131 xyz111131 approved these changes

@tsackton tsackton tsackton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwct @xyz111131 @tsackton